Skip to content

add code tab in five files. #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2023
Merged

add code tab in five files. #2753

merged 3 commits into from
Apr 3, 2023

Conversation

benluo
Copy link
Contributor

@benluo benluo commented Mar 20, 2023

No description provided.

julienrf
julienrf reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I approve the English files, but I need someone from @scala/docs-zh to approve the Chinese files.

@julienrf julienrf requested a review from a team March 31, 2023 12:12
julienrf
julienrf approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we can go ahead and merge it, thank you!

@julienrf julienrf merged commit 2be10cd into scala:main Apr 3, 2023
@benluo benluo deleted the zh-cn/overviews/scala3-book/types-inferred branch April 4, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benluo @julienrf